Pedro/cleanup forks #11
Conversation
otherview
force-pushed
the
pedro/cleanup_forks
branch
2 times, most recently
from
b7fb83c to
5105b34
Compare
otherview
force-pushed
the
pedro/cleanup_forks
branch
from
5105b34 to
fcc2486
Compare
otherview
force-pushed
the
pedro/cleanup_forks
branch
3 times, most recently
from
e6d0c12 to
164411e
Compare
otherview
force-pushed
the
pedro/cleanup_forks
branch
from
164411e to
71d6e14
Compare
| sudo apt-get update | ||
| sudo apt-get install -y make git build-essential | ||
|
|
||
| - name: Pull Docker Image |
There was a problem hiding this comment.
I guess this is because of the docker_test.go file, right? Should not this be pulled within the code? I can see actually at docker_node.go code trying to do so.
There was a problem hiding this comment.
Yeap! it's mainly to speed up things.
| Identity: thor.MustParseBytes32("0x0000000000000068747470733a2f2f617070732e7665636861696e2e6f72672f"), | ||
| Authority: []thorgenesis.Authority{ | ||
| { | ||
| MasterAddress: *SixNNAccount1.Address, |
There was a problem hiding this comment.
I am using these SixNN... as part of my config (I renamed them in my branch and put them in the preset file). Not sure whether they are meant to be reused or not. Is there a specifc reason not to? Tbh for the Galactica config I had in place I did not see the need to create from scratch more accounts.
To sum up, not sure if it makes sense to put common preset configuration somewhere (I picked preset.go but maybe there is a better home).
There was a problem hiding this comment.
Yeah it's incentivized to use those.
The presets are meant to be pre-defined network configurations. It's handy to avoid massive setups.
I think the design still needs a bit of work, for example I removed the hardcoding of the thor binary and added a check to make sure that if the preset is used in the local execution, the user of the preset would make sure to superseed the config and add a ExecArtifact path.
Describe your changes
Multiple cleanups + tech debt + update thor to v2.1.6
Issue ticket number and link
Checklist before requesting a review