Add Support for Cancelling Retries #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Gomez <[email protected]>
|
@vietj Here's my first pass at #46, let me know your thoughts. There is an issue resolving the dependencies for the latest snapshot (hence Travis CI failure), but it works if you switch back to an older version: diff --git a/pom.xml b/pom.xml
index 8b9ffae..b7afb9f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -23,7 +23,7 @@
</parent>
<artifactId>vertx-circuit-breaker</artifactId>
- <version>3.9.2-SNAPSHOT</version>
+ <version>3.9.0</version>Also, I wasn't sure if I should use |
These are common retry strategies, taken from: https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/ https://github.com/michaelbull/kotlin-retry/ Signed-off-by: Richard Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This fixes #46.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines