Support std::initializer_list parameters in the reverse mode #1212
+134
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetroZarytskyi
force-pushed
the
issue-1082
branch
from
f7aa743 to
473893e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PetroZarytskyi
force-pushed
the
issue-1082
branch
2 times, most recently
from
3d62efd to
330e841
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 94.56% 94.57%
=======================================
Files 51 51
Lines 8829 8842 +13
=======================================
+ Hits 8349 8362 +13
Misses 480 480
... and 1 file with indirect coverage changes
|
Previously, we replaced ``std::initializer_list`` variables with ``clad::array`` in the reverse mode so that they become modifiable. This PR moves the logic for type replacement from ``RMV::DifferentiateVarDecl`` to a``RMV::CloneType`` to use it to handle constructors with ``std::initializer_list`` parameters. Fixes vgvassilev#1082.
PetroZarytskyi
force-pushed
the
issue-1082
branch
from
2a20ea2 to
e175be7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we replaced
std::initializer_listvariables withclad::arrayin the reverse mode so that they become modifiable. This PR moves the logic for type replacement fromRMV::DifferentiateVarDeclto aRMV::CloneTypeto use it to handle constructors withstd::initializer_listparameters.Fixes #1082.