Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2783: Update detect-people.md #3223

Merged
merged 2 commits into from
Aug 9, 2024
Merged

DOCS-2783: Update detect-people.md #3223

merged 2 commits into from
Aug 9, 2024

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Aug 9, 2024

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Aug 9, 2024
@npentrel npentrel changed the title Update detect-people.md DOCS-2783: Update detect-people.md Aug 9, 2024
Copy link
Collaborator

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

@@ -97,9 +97,7 @@ Create the service.

In the resulting ML model service configuration pane, ensure that **Deploy model on machine** is selected for the **Deployment** field.

Click on **Select models** and select the `ml-models-scuttle:people` model from the registry (the **people** model by **ml-models-scuttle**) to deploy an object detection TFLite model that has been trained to be able to detect a person.

Click the **Save** button in the top right corner of the page to save your configuration and deploy an object detection TFLite model that has been trained to be able to detect a person.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we should still tell people to save it though. here I meant to repeat to drill it in ("tell show tell")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why though? they will be saving immediately again right after

@viambot
Copy link
Member

viambot commented Aug 9, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3223

@npentrel npentrel merged commit c8c45c0 into main Aug 9, 2024
10 checks passed
@npentrel npentrel deleted the npentrel-patch-3 branch August 9, 2024 18:00
npentrel added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants