RSDK-9706: Fix FTDC tracking of module restarts/crashes. #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dgottlieb
commented
Jan 10, 2025
| @@ -441,6 +441,9 @@ func main() { | |||
| nolintPrintln("reset range") | |||
| nolintPrintln("- Unset any prior range. \"zoom out to full\"") | |||
| nolintPrintln() | |||
| nolintPrintln("r, refresh") | |||
There was a problem hiding this comment.
Drive-by to document the "help" output for something I added in a prior PR.
| @@ -867,6 +867,10 @@ func (mgr *Manager) newOnUnexpectedExitHandler(mod *module) func(exitCode int) b | |||
| "error", err) | |||
| } | |||
|
|
|||
| if mgr.ftdc != nil { | |||
| mgr.ftdc.Remove(mod.getFTDCName()) | |||
There was a problem hiding this comment.
The bug fix for modules crashing -- this was just missing altogether before.
| @@ -1225,7 +1229,7 @@ func (m *module) stopProcess() error { | |||
| // of metrics will be reported. Therefore it is safe to continue monitoring the module process | |||
| // while it's in shutdown. | |||
| if m.ftdc != nil { | |||
| m.ftdc.Remove(m.process.ID()) | |||
| m.ftdc.Remove(m.getFTDCName()) | |||
There was a problem hiding this comment.
The happy path for a stop -> restart (presumably a module upgrade falls into this category).
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.