Update Ore/Herb Spawn Limits

[NickTyrer]

🍰 Pullrequest

Currently there are way to many active herb / ore spawns, this PR updates this data with manual counts from empty Classic Era Realms.

[ShiyoKozuki]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

[Daribon]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

Any examples?

[NickTyrer]

@ShiyoKozuki I am just focusing on getting the correct numbers of spawns for now as this alone will take a lot of time.

[ShiyoKozuki]

Any changes to spawn RATE? Some seem to spawn really, really fast in comparison to retail.

Any examples?

Practically all of them. I grinded on Classic era in ogre caves for 8-10 hours a day at release and it'd take 30m+ for any ore to respawn. They generally also wouldn't respawn in the exact same spot. They behave like how quest items(i.e. the feathers in winterspring) respawn in a random spot when picked up and not the exaxt same spot over and over again.

On this project, they respawn in <= 5m and always the same spots.

[NickTyrer]

This behaviour should only occur in STV, Desolace, Alterac Mountains and Dustwallow Marsh as I have only added pools to these zones recently.

[ShiyoKozuki]

How did you manually do this?

[ratkosrb]

He goes to an empty realm on Classic Era, then goes around the whole zone and counts how many ores of each kind are spawned.

[NickTyrer]

I use gathermate addon and do one pass of the zone for herbs another for mining nodes. Luckily I have had some help.

[ShiyoKozuki]

I added this PR to my server to test it out

I got the one 2 weeks ago but there's new stuff, however, it doesnt require me to run the migration because the database already has it set as "ran"

Since you're constantly updating the same migration, in order to get the newer change will I have to remove this migration from my migrations database then re-run it?

[ratkosrb]

It's not even merged yet. Just copy the actual updates inside the migration.

[ShiyoKozuki]

Is this looking into active "Rare" nodes"? They are extremely common here compared to classic era - I constantly am overloaded with truesilver, silver, and gold while it's extremely rare(even on dead servers) to find any of these nodes.
I was just in the Yeti cave here on vmangos and came out with 30+ silver ore in < 45m.

[NickTyrer]

Every zone with the exception of STV, Desolace, Alterac Mountains and Dustwallow Marsh has the chance % set for rare nodes to spawn. I will update the chance for the zones where chance is not set at a later date in a seperate PR.

[ShiyoKozuki]

Something is wrong with the % or there needs to be a max amount of rare spawns up per zone because I am constantly running around and seeing half of the zones full of silver/gold/truesilver and have never experienced that on classic era despite spending numerous days(in terms of total hours) inside of ogre and yeti caves on classic era.

[NickTyrer]

This is what they are set to 433e08f for the most part gold, silver and truesilver have a 10% spawn chance. What zone are the ogre and yeti caves in?

[ShiyoKozuki]

10% is very high, 5% would be more accurate
Hillsbrad, Arathi, blasted lands, deadwind pass, feralas, badlands, burning steppes, duskwood, alterac mountains, dun morogh, stv, loch modan

[NickTyrer]

The percentages are based on sniff data, I may update them if more data becomes available in the future. STV, Desolace, Alterac Mountains and Dustwallow Marsh dont have chance set so they will be incorrect.

[ShiyoKozuki]

I'm using this PR on my server right now
There was 3 silver veins inside of the hillsbrad yeti cave and then they kept spawning over and over, there was zero iron and only silver(4 silver veins total) when I first entered the cave.
The respawn rate seemed to be 5m on any ore veins inside the cave, resulting in a near infinite supply of ore to mine.
Your sniffed data says that's accurate? Because it's not what I experienced in classic era.

[NickTyrer]

I will have to recheck, are you talking about Darrow Hill?

[ShiyoKozuki]

Darrow hill specifically for this yes, but I have noticed this behavior in basically every cave on vmangos and this PR doesn't seem to change any of their behavior

[NickTyrer]

This PR wont fix those issues specifically (although significantly less spawns should reduce the chance for rare ores to spawn). I will open a PR in the future when more data is available, and will complete the zones that are incomplete.

[ShiyoKozuki]

Ok understood.
Thanks for this PR, it's very tedious and is a huge step to fixing ore/herb spawn availability.
I personally appreciate it a lot.

[ShiyoKozuki]

Ore nodes in STV are now working as they do in era, the same nodes do not respawn over and over every 5 minutes in the exact same spots.