Fix ci (#117)

* fix: correct issue with single file path going to root

found issue where if a single file is specified in instructions
that file tries to write to root which causes a read only file system error

Signed-off-by: Jeff Davis <[email protected]>

* ci: correct release and linter issues

Signed-off-by: Jeff Davis <[email protected]>

* ci: disable static err check on test

Signed-off-by: Jeff Davis <[email protected]>

.github/workflows/release.yml

@@ -36,11 +36,11 @@ jobs:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
-      -
-        name: Snapcraft Login
-        if: startsWith(github.ref, 'refs/tags/v')
-        run: |
-          snapcraft login --with <(echo "${{ secrets.SNAPCRAFT_LOGIN }}")
+      #-
+      #  name: Snapcraft Login
+      #  if: startsWith(github.ref, 'refs/tags/v')
+      #  run: |
+      #    snapcraft login --with <(echo "${{ secrets.SNAPCRAFT_LOGIN }}")
       -
         name: Import GPG key
         id: import_gpg

.golangci.yml

@@ -79,7 +79,7 @@ linters:
     # - exhaustivestruct
     - exportloopref
     - forbidigo
-    - forcetypeassert
+    #- forcetypeassert
     - funlen
     - gci
     - gochecknoglobals

.goreleaser.yml

@@ -61,7 +61,6 @@ dockers:
       - 'ghcr.io/vmware-tanzu-labs/yot:v{{ .Version }}'
       - 'ghcr.io/vmware-tanzu-labs/yot:latest'
     dockerfile: Dockerfile
-    use_buildx: true
     build_flag_templates:
       - "--label=org.opencontainers.image.created={{.Date}}"
       - "--label=org.opencontainers.image.name={{.ProjectName}}"
@@ -144,16 +143,16 @@ nfpms:
       - rpm
     recommends:
       - kubectl
-snapcrafts:
-  - name_template: '{{ .ProjectName }}_{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}'
-    name: yaml-overlay-tool
-    summary: "A YAML Overlay Tool with templating tendencies."
-    description: |
-      YAML Overlay Tool, or Yot for short, often pronounced /yaucht/, is a tool 
-      to assist with patching YAML files. Yot uses JSONPath to query YAML documents
-      within YAML files, and to perform a change. YAML Overlay Tool operates on YAML 
-      nodes. It is able to preserve and inject head, foot, and line comments into the 
-      new output versions of the files that you manipulate.
-    grade: stable
-    confinement: strict
-    publish: true
+# snapcrafts:
+#   - name_template: '{{ .ProjectName }}_{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}'
+#     name: yaml-overlay-tool
+#     summary: "A YAML Overlay Tool with templating tendencies."
+#     description: |
+#       YAML Overlay Tool, or Yot for short, often pronounced /yaucht/, is a tool 
+#       to assist with patching YAML files. Yot uses JSONPath to query YAML documents
+#       within YAML files, and to perform a change. YAML Overlay Tool operates on YAML 
+#       nodes. It is able to preserve and inject head, foot, and line comments into the 
+#       new output versions of the files that you manipulate.
+#     grade: stable
+#     confinement: strict
+#     publish: true

internal/actions/actions_test.go

@@ -93,7 +93,7 @@ func (tst testCases) runTests(t *testing.T, a string) {
 			results, _ := yp.Find(testYaml)
 
 			if err := testAction(t, a, results[0], testYaml, val.Content...); (err != nil) != testCase.wantErr {
-				t.Errorf("Error: %w, WantErr: %v", err, testCase.wantErr)
+				t.Errorf("Error: %v, WantErr: %v", err, testCase.wantErr)
 			}
 
 			buf := new(bytes.Buffer)

internal/commands/completion_test.go

@@ -81,7 +81,7 @@ func TestCompletions(t *testing.T) {
 
 			defer func() {
 				if err := recover(); err != nil {
-					newErr := fmt.Errorf("%w", err)
+					newErr := fmt.Errorf("%v", err) //nolint
 
 					if !test.wantErr && newErr != nil {
 						t.Errorf("Completions() error = %v, wantErr %v", err, test.wantErr)