Fix shutdown method #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, it wasn't working correctly. Sending the shell command "reboot -p" triggers a power down.
|
This fix is changing the functionality of the method. Previous it was doing the same as pushing the power button, now it is entering the shutdown command in the adb shell. I suggest that the old functionality should remain, however should be referred to as |
ghost
approved these changes
Dec 18, 2018
irvingswiftj
suggested changes
Dec 18, 2018
There was a problem hiding this comment.
This fix is changing the functionality of the method. Previous it was doing the same as pushing the power button, now it is entering the shutdown command in the adb shell.
I suggest that the old functionality should remain, however should be referred to as standby, and not shutdown
dpascu
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, it wasn't working correctly. With this change, sending the shell command "reboot -p" triggers a power down.