Improve collect_unicast_peers #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frank-f can you please rebase? |
|
this looks a bit odd. The PR contains commits that are already in master. Can you take a look again and rebase please? If you've questions about it you can always join our IRC channel #voxpupuli on Libera.Chat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
As described in #304, collect_unicast_peers will add the local source IP to the list of unicast_peers. Currently this is a rather cosmetic problem, but it may confuse someone unfamiliar with the module who's looking at the configuration file.
Also, the ideal contents for unicast_src_ip which will match the rest of the configuration is determined by the module, but it is never explicitly added to it. Instead we're relying on Keepalived to come to the same result. I added it to the template (still overridable by setting unicast_source_ip explicitly) and moved it's fragment below "if $collect_unicast_peers" for this to work.
This Pull Request (PR) fixes the following issues
Fixes #304