feat[venom]: multidimensional fencing #4066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extract IRLiterals which are instruction arguments; this reduces pressure on the stack scheduler
This reverts commit e087c4f.
charles-cooper
force-pushed
the
feat/fencing
branch
from
7fa84b4 to
20bd8b3
Compare
| def run_pass(self): | ||
| dfg = self.analyses_cache.request_analysis(DFGAnalysis) | ||
| self.analyses_cache.request_analysis(CFGAnalysis) | ||
| liveness = self.analyses_cache.force_analysis(LivenessAnalysis) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| """ | ||
| uses = dfg.get_uses(var) | ||
|
|
||
| _cache = {} |
Check notice
Code scanning / CodeQL
Unused local variable Note
| # start with out liveness | ||
| #if len(bb.cfg_out) > 0: | ||
| if False: | ||
| next_bb = bb.cfg_out.first() |
Check warning
Code scanning / CodeQL
Unreachable code Warning
|
superseded by #4255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture