feat[venom]: binopt #4281
Open
feat[venom]: binopt #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
+ Coverage 92.01% 92.11% +0.10%
==========================================
Files 119 119
Lines 16692 16944 +252
Branches 2805 2872 +67
==========================================
+ Hits 15359 15608 +249
- Misses 915 918 +3
Partials 418 418 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
force-pushed
the
feat/binopt
branch
from
7cc3d08 to
2641f39
Compare
change to lit_eq so that it catches more cases of equality optimization: don't interfere with sccp rule
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import vyper.venom.effects as effects | |||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.utils import OrderedSet, wrap256 | |||
Check notice
Code scanning / CodeQL
Unused import Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Started reimplementing the binary operation optimization and some additional from original pipeline to venom pipeline
How I did it
The optimization are done in the
AlgebraicOptimizationPasssince the types of optimizations nicely slots into the purpose of the pass. Most of the logic is directly taken from the original pipelineHow to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture