-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[lang]: remove VyperNode __hash__()
and __eq__()
implementations
#4433
Merged
charles-cooper
merged 9 commits into
vyperlang:master
from
charles-cooper:perf/vypernode-hash
Jan 12, 2025
Merged
refactor[lang]: remove VyperNode __hash__()
and __eq__()
implementations
#4433
charles-cooper
merged 9 commits into
vyperlang:master
from
charles-cooper:perf/vypernode-hash
Jan 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a performance and correctness footgun for the hash and eq implementations to recurse. for instance, two nodes from different source files should never compare equal (you can use deepequals to signal intention there). this commit temporarily overrides the `__ne__` implementation for VyperNode so that we can find all the `!=` uses in the tests.
since we no longer need to worry about __hash__ and __eq__performance
charles-cooper
changed the title
refactor[lang]: remove VyperNode __hash__ and __eq__ implementations
refactor[lang]: remove VyperNode Jan 1, 2025
__hash__()
and __eq__()
implementations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4433 +/- ##
==========================================
+ Coverage 91.98% 91.99% +0.01%
==========================================
Files 119 119
Lines 16686 16673 -13
Branches 2808 2803 -5
==========================================
- Hits 15348 15339 -9
+ Misses 919 916 -3
+ Partials 419 418 -1 ☔ View full report in Codecov by Sentry. |
cyberthirst
approved these changes
Jan 12, 2025
cyberthirst
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a performance and correctness footgun for the hash and eq implementations to recurse. for instance, two nodes from different source files should never compare equal (you can use deepequals to signal intention there).
i refactored the test suite by temporarily overriding the
__ne__
implementation for VyperNode so that we can find all the!=
uses in the tests. the CI for this commit (0a9830b) passes (run https://github.com/vyperlang/vyper/actions/runs/12574333551/), and the training wheels are taken off in commit 71726ad.What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture