feat: Specify AtVersion for automation (#1144)

* Virtual property for AtVersion.supportedByAutomation * Ensure that supportedByAutomation is testing in graphql query test * Do not provide option to run with automation when minimum/exact at version reqs not supported by automation * Support specifying required version to runner * Version reporting for mock automation * Support minimum version * Pass macos_version workflow input when scheduling VoiceOver jobs * Add test coverage * Ensure correct os number sent to VoiceOver runner * Remove errant log * Ref and comment update after aria-at-gh-actions-helper merge * Update server/util/getAtVersionWithRequirements.js Co-authored-by: Mx Corey Frang <[email protected]> * Move query updates to new TestQueue * Update mock for DataManagePage and TestPlanReportStatusDialog, fix incorrect query after merge resolution * Update to handle merge conflicts * Correct dump test data with version recent enough for unit tests * Correct version in dump test data * JSDoc update for triggerWorkflow, fix missing arg in triggerWorkflow call, add issue link to comment, constants for at/browser combo check --------- Co-authored-by: Mx Corey Frang <[email protected]>
w3c · Jul 17, 2024 · 52865e2 · 52865e2
1 parent c913504
commit 52865e2
Show file tree

Hide file tree

Showing 20 changed files with 890 additions and 123 deletions.
diff --git a/client/components/AddTestToQueueWithConfirmation/index.jsx b/client/components/AddTestToQueueWithConfirmation/index.jsx
@@ -102,7 +102,9 @@ function AddTestToQueueWithConfirmation({
 
   const hasAutomationSupport = isSupportedByResponseCollector({
     at,
-    browser
+    browser,
+    minimumAtVersion,
+    exactAtVersion
   });
 
   const alreadyHasBotInTestPlanReport = useMemo(
@@ -328,10 +330,25 @@ AddTestToQueueWithConfirmation.propTypes = {
   at: PropTypes.shape({
     id: PropTypes.string.isRequired,
     key: PropTypes.string.isRequired,
-    name: PropTypes.string.isRequired
+    name: PropTypes.string.isRequired,
+    atVersions: PropTypes.arrayOf(
+      PropTypes.shape({
+        id: PropTypes.string.isRequired,
+        name: PropTypes.string.isRequired,
+        supportedByAutomation: PropTypes.bool.isRequired
+      })
+    )
+  }),
+  exactAtVersion: PropTypes.shape({
+    id: PropTypes.string,
+    name: PropTypes.string,
+    supportedByAutomation: PropTypes.bool
+  }),
+  minimumAtVersion: PropTypes.shape({
+    id: PropTypes.string,
+    name: PropTypes.string,
+    supportedByAutomation: PropTypes.bool
   }),
-  exactAtVersion: PropTypes.object,
-  minimumAtVersion: PropTypes.object,
   buttonRef: PropTypes.object,
   onFocus: PropTypes.func,
   onBlur: PropTypes.func,

diff --git a/client/components/DataManagement/queries.js b/client/components/DataManagement/queries.js
@@ -20,6 +20,7 @@ export const DATA_MANAGEMENT_PAGE_QUERY = gql`
         id
         name
         releasedAt
+        supportedByAutomation
       }
       candidateBrowsers {
         id

diff --git a/client/components/TestPlanReportStatusDialog/queries.js b/client/components/TestPlanReportStatusDialog/queries.js
@@ -22,6 +22,12 @@ export const TEST_PLAN_REPORT_STATUS_DIALOG_QUERY = gql`
           id
           key
           name
+          atVersions {
+            id
+            name
+            supportedByAutomation
+            releasedAt
+          }
         }
         browser {
           id
@@ -31,10 +37,14 @@ export const TEST_PLAN_REPORT_STATUS_DIALOG_QUERY = gql`
         minimumAtVersion {
           id
           name
+          supportedByAutomation
+          releasedAt
         }
         exactAtVersion {
           id
           name
+          supportedByAutomation
+          releasedAt
         }
         testPlanReport {
           id

diff --git a/client/components/TestQueue/AssignTesters.jsx b/client/components/TestQueue/AssignTesters.jsx
@@ -236,7 +236,9 @@ const AssignTesters = ({ me, testers, testPlanReport }) => {
       const supportedByResponseCollector = isSupportedByResponseCollector({
         id: testPlanReport.id,
         at: testPlanReport.at,
-        browser: testPlanReport.browser
+        browser: testPlanReport.browser,
+        minimumAtVersion: testPlanReport.minimumAtVersion,
+        exactAtVersion: testPlanReport.exactAtVersion
       });
       if (!foundAtForBot || !supportedByResponseCollector) return null;
     }
@@ -353,13 +355,28 @@ AssignTesters.propTypes = {
     at: PropTypes.shape({
       id: PropTypes.string.isRequired,
       name: PropTypes.string.isRequired,
-      key: PropTypes.string.isRequired
+      key: PropTypes.string.isRequired,
+      atVersions: PropTypes.arrayOf(
+        PropTypes.shape({
+          id: PropTypes.string.isRequired,
+          name: PropTypes.string.isRequired,
+          supportedByAutomation: PropTypes.bool.isRequired
+        })
+      )
     }).isRequired,
     browser: PropTypes.shape({
       id: PropTypes.string.isRequired,
       name: PropTypes.string.isRequired,
       key: PropTypes.string.isRequired
-    }).isRequired
+    }).isRequired,
+    minimumAtVersion: PropTypes.shape({
+      id: PropTypes.string.isRequired,
+      name: PropTypes.string.isRequired
+    }),
+    exactAtVersion: PropTypes.shape({
+      id: PropTypes.string.isRequired,
+      name: PropTypes.string.isRequired
+    })
   }).isRequired
 };
 

diff --git a/client/components/TestQueue/queries.js b/client/components/TestQueue/queries.js
@@ -25,6 +25,7 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
         id
         name
         releasedAt
+        supportedByAutomation
       }
       browsers {
         id
@@ -49,6 +50,12 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
             id
             key
             name
+            atVersions {
+              id
+              name
+              supportedByAutomation
+              releasedAt
+            }
           }
           browser {
             id
@@ -58,10 +65,13 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
           minimumAtVersion {
             id
             name
+            supportedByAutomation
+            releasedAt
           }
           exactAtVersion {
             id
             name
+            supportedByAutomation
           }
           runnableTestsLength
           conflictsLength
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,6 +20,7 @@ export const DATA_MANAGEMENT_PAGE_QUERY = gql` @@
             id
             name
             releasedAt
+            supportedByAutomation
           }
           candidateBrowsers {
             id
@@ Expand Down @@