Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior note follow up #596

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Unexpected behavior note follow up #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0309dfc
Remove other unexpected behavior text
alflennik Jul 26, 2022
0a276ce
Iron out kinks
alflennik Jul 26, 2022
5a3f0fa
Attempt to fix CI
alflennik Jul 26, 2022
06d0124
Set up test renderer for editing
alflennik Jul 26, 2022
55740cd
Attempt to update test renderer
alflennik Jul 28, 2022
b7b0f08
Update test renderer, not complete
alflennik Aug 2, 2022
6733890
Set up prettier to be closer to aria-at repo
alflennik Aug 8, 2022
c4877d9
Fix several bugs
alflennik Aug 9, 2022
89b7f35
Fix tests
alflennik Aug 9, 2022
aa4bfc9
Fix validation bug
alflennik Aug 9, 2022
9a2c147
Remove log
alflennik Aug 9, 2022
658569f
Fixing migration
evmiguel Aug 9, 2022
e79fa1d
Merge branch 'main' into unexpected-behavior-note-2
evmiguel Mar 29, 2023
be7afef
fixing downstream bug to testrenderer from remap state in testrun
evmiguel Apr 3, 2023
18ff6fc
fixing submit/save bug
evmiguel Apr 4, 2023
64e9ae3
fixing testrenderer/testrun data formatting
evmiguel Apr 5, 2023
a2600a8
Removing TODO
evmiguel May 3, 2023
e7d0a05
support for expanded unexpected behaviors and scroll
evmiguel May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/components/CandidateTests/CandidateTestPlanRun/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ export const CANDIDATE_REPORTS_QUERY = gql`
unexpectedBehaviors {
id
text
otherUnexpectedBehaviorText
}
unexpectedBehaviorNote
}
}
draftTestPlanRuns {
Expand Down
7 changes: 3 additions & 4 deletions client/components/Reports/SummarizeTestPlanReport.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,10 @@ SummarizeTestPlanReport.propTypes = {
unexpectedBehaviors: PropTypes.arrayOf(
PropTypes.shape({
id: PropTypes.string.isRequired,
text: PropTypes.string.isRequired,
otherUnexpectedBehaviorText:
PropTypes.string
text: PropTypes.string.isRequired
}).isRequired
).isRequired
).isRequired,
unexpectedBehaviorNote: PropTypes.string
}).isRequired
).isRequired
}).isRequired
Expand Down
14 changes: 14 additions & 0 deletions client/components/Reports/TestPlanResultsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,20 @@ const TestPlanResultsTable = ({ test, testResult, tableClassName = '' }) => {
</li>
)
)}
{scenarioResult.unexpectedBehaviorNote ? (
<div>
Explanation:&nbsp;
<em>
&quot;
{
scenarioResult.unexpectedBehaviorNote
}
&quot;
</em>
</div>
) : (
''
)}
</ul>
) : (
'None'
Expand Down
2 changes: 1 addition & 1 deletion client/components/Reports/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ export const REPORT_PAGE_QUERY = gql`
unexpectedBehaviors {
id
text
otherUnexpectedBehaviorText
}
unexpectedBehaviorNote
}
}
draftTestPlanRuns {
Expand Down
24 changes: 14 additions & 10 deletions client/components/ReviewConflicts/ReviewConflicts.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,23 @@ const ReviewConflicts = ({
const { testPlanRun, scenarioResult } = result;
let resultFormatted;
if (scenarioResult.unexpectedBehaviors.length) {
resultFormatted = scenarioResult.unexpectedBehaviors
.map(({ otherUnexpectedBehaviorText, text }) => {
return `"${otherUnexpectedBehaviorText ?? text}"`;
})
.join(' and ');
resultFormatted =
'the unexpected behavior ' +
scenarioResult.unexpectedBehaviors
.map(({ text }) => `"${text.toLowerCase()}"`)
.join(' and ');
} else {
resultFormatted = 'no unexpected behavior';
}
let noteFormatted = scenarioResult.unexpectedBehaviorNote
? ` with the explanation ` +
`"${scenarioResult.unexpectedBehaviorNote}"`
: '';
return (
<li key={testPlanRun.id}>
Tester {testPlanRun.tester.username} recorded output &quot;
{scenarioResult.output}&quot; and noted {resultFormatted}.
{scenarioResult.output}&quot; and noted&nbsp;
{resultFormatted + noteFormatted}.
</li>
);
});
Expand Down Expand Up @@ -160,11 +165,10 @@ ReviewConflicts.propTypes = {
output: PropTypes.string.isRequired,
unexpectedBehaviors: PropTypes.arrayOf(
PropTypes.shape({
text: PropTypes.string.isRequired,
otherUnexpectedBehaviorText:
PropTypes.string
text: PropTypes.string.isRequired
})
).isRequired
).isRequired,
unexpectedBehaviorNote: PropTypes.string
}),
assertionResult: PropTypes.shape({
passed: PropTypes.bool.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion client/components/TestPlanUpdater/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ export const VERSION_QUERY = gql`
}
unexpectedBehaviors {
id
otherUnexpectedBehaviorText
}
unexpectedBehaviorNote
}
}
}
Expand Down
Loading