Refactor CLI tests and improvements on the -version option
#1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the definitions of configuration-related steps in two classes: - `TestEnvironment` contains generic test configuration steps, like setting the locale or the location of test files - `EPUBCheckConfiguration` contains the steps used to conifugre an EPUBCheck instance (version, mode, profile, etc)
- Allow using the version option when checking a file. The CLI will display the version info and the carry on checking the file. - The "EPUBCheck completed" message, along with the short stats on messages (fatals/errors/warnings/infos) is no longer displayed when the CLI only displays informational output (help message or version). Fixes #1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-versionto be used when checking a file