Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue989 concerning timezone specific issue in rest analyses (part 5) #990

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

vincentvanhees
Copy link
Member

Fixes #989

Problem was that timestamps were not converted to POSIXct while they should have which caused timezone specific results.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7addc38) 78.40% compared to head (dc87d72) 78.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   78.40%   78.41%           
=======================================
  Files          99       99           
  Lines       13371    13371           
=======================================
+ Hits        10484    10485    +1     
+ Misses       2887     2886    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentvanhees vincentvanhees marked this pull request as ready for review December 6, 2023 11:43
@vincentvanhees vincentvanhees merged commit ededec3 into master Dec 6, 2023
10 checks passed
@vincentvanhees vincentvanhees deleted the issue989_macosarm64 branch December 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos error on CRAN
1 participant