chore: fix typos #2134
Closed
chore: fix typos #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vpavlin build-docker-image ci is failing. doesnt seem related, any idea? |
Ivansete-status
approved these changes
Oct 27, 2023
|
Hey @omahs ! |
* feat: amending computeDigest func. + related test cases * minor fixes * minor fixes v1: testcase saga continues --------- Co-authored-by: Vaclav Pavlin <[email protected]>
* libwaku: Avoid global variable and changing callback signature * Better signature for the callback. Two new parameters have been added: one aimed to allow passing the caller result code; the other param is to pass an optional userData pointer that might need to be linked locally with the Context object. For example, this is needed in Rust to make the passed closures live as long as the Context. * waku_example.c: adaptation to the latest changes * libwaku.h: removing 'waku_set_user_data' function * libwaku.nim: renaming parameter in WakuCallBack (isOk -> callerRet)
* feat: messageHash attaribute added in SQLite + testcase * Update tests/waku_archive/test_driver_sqlite_query.nim Co-authored-by: Ivan FB <[email protected]> --------- Co-authored-by: Ivan FB <[email protected]>
…org#2142)" (waku-org#2154) This reverts commit 9cd8c73.
|
@Ivansete-status Hey, sorry I messed up my branch. I opened another squashed PR here: #2232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typos