feat: metadata protocol shard subscription #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
added
the
E:1.4: Sharded peer management and discovery
|
You can find the image built from this PR at Built from accfeb7 |
SionoiS
force-pushed
the
feat--metadata-protocol-shard-subscription
branch
3 times, most recently
from
a1614cc to
b0c3c2c
Compare
alrevuelta
requested changes
Oct 25, 2023
For the subscription part? Sure! |
SionoiS
force-pushed
the
feat--metadata-protocol-shard-subscription
branch
2 times, most recently
from
b9f2f14 to
994b9d4
Compare
Ivansete-status
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
LGTM! Thanks for it!
Just added a few nitpicks but not blocking ones :)
On the other hand, I realized that the metadata protocol is being mounted within the creation of the Waku node. Why is that needed @alrevuelta? I wonder if we could follow the standard approach that we are following in other protocols so that all is more consistent.
SionoiS
force-pushed
the
feat--metadata-protocol-shard-subscription
branch
from
0501ad1 to
cb1d31b
Compare
jm-clius
approved these changes
Oct 30, 2023
SionoiS
force-pushed
the
feat--metadata-protocol-shard-subscription
branch
from
cb1d31b to
31ea8e3
Compare
SionoiS
force-pushed
the
feat--metadata-protocol-shard-subscription
branch
from
31ea8e3 to
c19b92a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The shards a node support can dynamically changes and the metadata protocol must be updated at run-time to reflect this.
Changes
Tracking #1940
Fix #2105