Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize store types by using camel case instead of snake case #2709

Merged
merged 1 commit into from
May 17, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Standardize the case use by all REST endpoints' attributes. We are using CamelCase

Issue

closes #2582

@Ivansete-status Ivansete-status marked this pull request as ready for review May 17, 2024 10:49
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2709-rln-v1

Built from 1f16751

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2709-rln-v2

Built from 1f16751

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So satisfying 😌 haha
Thanks so much!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!!!

@Ivansete-status Ivansete-status merged commit 176c98c into master May 17, 2024
15 of 16 checks passed
@Ivansete-status Ivansete-status deleted the standardize-rest-camel-case branch May 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: contentTopic naming not consistent in the store response where is's content_topic
3 participants