chore: modifying relay subscribe return value

[gabrielmer]

Description

Currently, WakuRelay.subscribe() has a return value that is discarded everywhere except in one place. It returns the wrapped handler that is passed to gossipsub, which is useless to most cases when we subscribe to a topic.

Therefore, defined a wrapHandler() procedure to return the wrapped handler in the specific cases that is needed, and changed the return type of subscribe to void so we don't have to discard that value everywhere

Changes

• changed return value of WakuRelay.subscribe() to void
• defined a wrapHandler() procedure in the waku_relay module

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3214

Built from 6da1bd1

[gabrielmer]

Well, looking at the failed test I noticed that we do need to pass the wrapped handler when calling unsubscribe (as unsubscribing is from a specific handler). So maybe it does sense to return it and this PR is irrelevant? LMK what you think

[Ivansete-status]

Well, looking at the failed test I noticed that we do need to pass the wrapped handler when calling unsubscribe (as unsubscribing is from a specific handler). So maybe it does sense to return it and this PR is irrelevant? LMK what you think

Thanks for this!
IMO, we need to allow subscription and unsubscription but it shouldn't be needed to deal with any handler at all to unsubscribe. The only parameters needed to subscribe/unsubscribe should be the pubsubTopic , a.k.a. cluster-id+shard

[gabrielmer]

Thanks for this! IMO, we need to allow subscription and unsubscription but it shouldn't be needed to deal with any handler at all to unsubscribe. The only parameters needed to subscribe/unsubscribe should be the pubsubTopic , a.k.a. cluster-id+shard

I understand not dealing with handlers when unsubscribing, but I think we do need to have a handler as a parameter when subscribing right? the idea of subscribing is running a custom procedure when a message is received, it seems as it is really important to be able to define and pass that procedure through. But I might be missing something :))

[Ivansete-status]

I understand not dealing with handlers when unsubscribing, but I think we do need to have a handler as a parameter when subscribing right? the idea of subscribing is running a custom procedure when a message is received, it seems as it is really important to be able to define and pass that procedure through. But I might be missing something :))

Yes you are right ! Nevertheless, I think we only need one handler for all subscriptions. f.e., in libwaku we are passing the same handler to all subscriptions :)

[gabrielmer]

After further discussions, opened issue #3222 and closing this PR :)