Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimize libwaku size #3242

Merged
merged 4 commits into from
Jan 16, 2025
Merged

chore: Optimize libwaku size #3242

merged 4 commits into from
Jan 16, 2025

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Jan 15, 2025

Description

This PR aims for reducing the resulting libwaku library size

improvements to reduce libwaku's size

  • Avoid compiling libwaku with -d:chronicles_log_level='TRACE'
  • Avoid adding too large seq of strings in waku/waku_rln_relay/constants.nim as it is only needed by tests. Change in constants.nim:
    image

Note

In Linux, the command size build/libwaku.a is very interesting to see which module occupies more space.

Issue

closes #3241

Copy link

github-actions bot commented Jan 15, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3242

Built from d2c2888

@Ivansete-status Ivansete-status marked this pull request as ready for review January 16, 2025 07:29
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I like it much! Thanks.

@gabrielmer
Copy link
Contributor

Amazinggg! Thanks so much!

@Ivansete-status Ivansete-status merged commit 9c0ad85 into master Jan 16, 2025
12 of 13 checks passed
@Ivansete-status Ivansete-status deleted the optimize-libwaku-size branch January 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: libwaku size optimizations
3 participants