Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(weave): remove unneeded expand_columns param #3486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(weave): remove unneeded expand_columns param #3486

wants to merge 1 commit into from

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Jan 23, 2025 •
edited
Loading

Remove unused param. Expand columns shouldn't do anything in the sdk because we resolve refs recursively anyway.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 23, 2025 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=97ce37edbb88ab1e34b6b114aa0f771fa3144921

@gtarpenning gtarpenning marked this pull request as ready for review January 23, 2025 21:08
@gtarpenning gtarpenning requested a review from a team as a code owner January 23, 2025 21:08
@andrewtruong
Copy link
Collaborator

What does expand columns do?

@gtarpenning
Copy link
Member Author

What does expand columns do? @andrewtruong

This pushes ref expansion to the server. We don't need this in the SDK because of make_trace_obj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtruong andrewtruong andrewtruong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtarpenning @andrewtruong