Allow use of breakpoints instead of user-agent sniffing #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some companies use only breakpoints to determine whether a device is mobile or desktop. This option allows those companies to more closely align device detection with their own policies.
design1online
suggested changes
Jan 6, 2020
| /** | ||
| * @desc Determines if the user is using a Retina display. | ||
| **/ | ||
| Retina() { |
There was a problem hiding this comment.
Why are you adding a retina option if you don't use it anywhere?
| * @desc Determines if the user is using a mobile device. | ||
| **/ | ||
| any() { | ||
| return (window.innerWidth < this.desktopBreakpoint); |
There was a problem hiding this comment.
This needs a more descriptive function name. Also what happens if the window isn't available -- you should check for the window !== undefined.
| @@ -12,7 +13,11 @@ export class ArcAds { | |||
| this.positions = []; | |||
| this.collapseEmptyDivs = options.dfp.collapseEmptyDivs; | |||
|
|
|||
| window.isMobile = MobileDetection; | |||
| if (options.desktopBreakpoint) { | |||
| window.isMobile = new BreakpointDetection(options.desktopBreakpoint); | |||
There was a problem hiding this comment.
This should also have support for tablet/mobile breakpoints in order to be considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some publishers use only breakpoints to determine whether a device is mobile or desktop. This option allows those companies to more closely align device detection with their own policies.
This came up during testing of an unrelated issue. The Chrome developer tools device toolbar will modify the user-agent to appear like an Android device, even at widescreen values, preventing our right-rail ad from loading.
On this branch
Adds option to ArcAds initialization to specify a desktop breakpoint using the
desktopBreakpointproperty. If present, that overrides the user-agent-based device detection.Verify
Confirm that cross browser testing has been completed.
Verify that no errors are present in the GPT console
window.googletag.openConsole().Comments
Sample initialization code: