feat(examples): Migrates remaining go examples from monorepo #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a note, I only updated docs of the examples I moved over. My next follow up will be updating the docs for the other examples |
thomastaylor312
force-pushed
the
feat/migrate_examples
branch
3 times, most recently
from
8e1f3a4 to
73b33ea
Compare
joonas
reviewed
Dec 18, 2024
joonas
requested changes
Dec 18, 2024
There was a problem hiding this comment.
We need to figure out a different way to handle deploying the components if that's something that's going to be tested as part of the pipeline, the bash script that's used in the main repository is super flaky and I would rather not introduce that into this repo's CI.
thomastaylor312
force-pushed
the
feat/migrate_examples
branch
2 times, most recently
from
b8988ff to
f1fb78a
Compare
This moves the two examples that weren't moved from the monorepo. This also adds tests and adds simple smoke tests for each component. I also modified the examples job to run once per week to ensure things don't go stale with new versions of `wash` Signed-off-by: Taylor Thomas <[email protected]>
thomastaylor312
force-pushed
the
feat/migrate_examples
branch
from
f1fb78a to
2560a87
Compare
|
For reference, I was looking at many of the recent flakes in the main repo and all of them seem to fail with I think my new way of doing it solves this issue |
joonas
reviewed
Dec 18, 2024
…er examples Signed-off-by: Taylor Thomas <[email protected]>
thomastaylor312
force-pushed
the
feat/migrate_examples
branch
from
c3acea5 to
69ec4cc
Compare
joonas
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the two examples that weren't moved from the monorepo. This also adds tests and adds simple smoke tests for each component. I also modified the examples job to run once per week to ensure things don't go stale with new versions of
wash