NODE-2596 Optimised active leases #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-mashonskiy
approved these changes
Oct 5, 2023
vsuharnikov
approved these changes
Oct 6, 2023
phearnot
requested changes
Nov 6, 2023
There was a problem hiding this comment.
- Instead of copying lease details to sender and recipient accounts, store only lease IDs (just like for address transactions).
- Add a test which checks that cancelled leases are excluded from the response.
- Add a test to check if rollback works (for both active and cancelled leases).
| @@ -60,7 +53,8 @@ object CommonAccountsApi { | |||
| def apply( | |||
| compositeBlockchain: () => SnapshotBlockchain, | |||
| rdb: RDB, | |||
| blockchain: Blockchain | |||
| blockchain: Blockchain, | |||
| leaseStatesAreStoredByAddress: Boolean | |||
DrBlast
approved these changes
Nov 29, 2023
phearnot
force-pushed
the
node-2596-optimised-active-leases
branch
from
8f87f55 to
d1e4bbd
Compare
phearnot
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.