Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security group to a few features #2061

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Oct 23, 2024

Wondering which existing features should belong into the newly created security group for w3c-cg/swag#2. So far we have:

  • CSP
  • Trusted Types (this PR)

Maybe there is more? @wbamberg, do you want to look through https://web-platform-dx.github.io/web-features-explorer/groups/ to see if anything should be added to the group as well?

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 23, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but leaving it unmerged for Will's consideration. Feel free to merge when you like.

@Elchi3 Elchi3 changed the title Add Trusted Types to security group Add security group to a few features Oct 29, 2024
@Elchi3
Copy link
Collaborator Author

Elchi3 commented Oct 29, 2024

Thanks Will, I added the security group to a few more existing features as you suggested. I left out the CM features for now, because, as you say, these might fit better in an "Authentication" group. Features can also be part of several groups. (There are no strict rules around groups yet)

@ddbeck ddbeck merged commit 4277ec4 into web-platform-dx:main Oct 30, 2024
3 checks passed
@Elchi3 Elchi3 deleted the sec-group branch October 30, 2024 16:09
vwallen pushed a commit to oddbird/web-features that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants