Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding: make it clear sniffing for UTF-8 is not acceptable #14455

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Encoding: make it clear sniffing for UTF-8 is not acceptable #14455

merged 1 commit into from
Dec 12, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 11, 2018

See whatwg/encoding#68 for background.

inexorabletash
inexorabletash approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor tidbit might be that seeing the content in the results looks ugly - maybe 'display: none' the content.

@annevk annevk merged commit 305ff11 into master Dec 12, 2018
@annevk
Copy link
Member Author

annevk commented Dec 12, 2018

I did consider that, but it seems that would make debugging harder than it needs to be and mostly bots will see these results anyway.

@annevk annevk deleted the no-sniffing branch December 12, 2018 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inexorabletash inexorabletash inexorabletash approved these changes

Assignees

@inexorabletash inexorabletash

Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @inexorabletash @wpt-pr-bot