Improve user experience: change compression method to deflate
#348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Changes proposed in this PR
.deflate
atzipItem(at:to:shouldKeepParent:compressionMethod:progress)
Tests performed
true
Further info for the reviewer
In the software development industry, it’s a widely accepted convention for libraries to default to a “compressed” output rather than “uncompressed.” For instance, popular libraries like
ZipArchive
andminizip
are designed so that when users provide a source URL and a destination URL, the output at the destination is a compressed zip file by default. This aligns with user expectations and typical workflows.Currently, ZipFoundation’s default setting is
.none
, which generates an uncompressed zip. While this is a valid design choice, it may cause confusion for users who assume the output will follow the standard behavior seen in similar libraries. In most practical use cases, whether in daily development or production environments, users are looking to create a compressed zip file rather than one that is simply a copy of the input.To provide a smoother user experience and align with industry best practices, I would suggest changing the default value to .deflate. This small adjustment could make the library more intuitive and user-friendly.
Open Issues
none