Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update download inspire schemas #5

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: update download inspire schemas #5

merged 2 commits into from
Feb 8, 2024

Conversation

emanuelaepure10
Copy link
Contributor

Update for using the new way of downloading the INSPIRE schemas. Code compliant with hale-platform

ING-3392

stempler
stempler requested changes Jan 25, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@stempler
Copy link
Member

@emanuelaepure10 I did an update to the repository to (a) automate update to the resources (daily update, PR is created for review with changes) and (b) perform checks on PRs to verify the download and possible changes that would happen during the automated updates.

before that the folder with the host name should be cleared/recreated, so no old files remain

This now needs to be done similar to here:

offline-resources/build.gradle

Line 225 in faddb31

md.cleanFolderKeepMetadata()

create a metadata file similar to the existing download tasks

This now needs to be done similar to here:

offline-resources/build.gradle

Line 236 in faddb31

md.setVersionIfChanged()

@emanuelaepure10
Copy link
Contributor Author

@stempler
Do you have any recommendations for the next steps?
Could a trigger for a new build in Kelvin be the right step?
Thank you

@emanuelaepure10 emanuelaepure10 self-assigned this Jan 26, 2024
stempler
stempler reviewed Feb 1, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@emanuelaepure10 emanuelaepure10 force-pushed the feat/ING-3392 branch 8 times, most recently from 0b05a51 to 16a30c1 Compare February 5, 2024 22:19
@emanuelaepure10
Copy link
Contributor Author

Locally, the build was successful for me. However, I've encountered difficulties reproducing the same success in this environment. Despite trying various approaches, I haven't been able to achieve the desired outcome. Do you have any suggestions for improvements that I could try?

stempler
stempler reviewed Feb 6, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@emanuelaepure10 emanuelaepure10 force-pushed the feat/ING-3392 branch 2 times, most recently from 32818cb to 0ec93e9 Compare February 6, 2024 22:24
stempler
stempler reviewed Feb 6, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
stempler
stempler reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes! Can you please still fix the indentation for all of the changes?

@emanuelaepure10
feat: update download inspire schemas
8e4ae19 
Update for using the new way of downloading the INSPIRE schemas.

ING-3392
@emanuelaepure10
Copy link
Contributor Author

The indentation should be fixed now.

stempler
stempler approved these changes Feb 8, 2024
View reviewed changes
build.gradle Outdated

File applicationtempschemas = new File(temporaryDir, 'application-schemas-main')
File tempRoot = new File(applicationtempschemas, 'tmp-schemas')
def versions = ['2021.1', '2021.2', '2022.1', '2022.2']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing. Since you pointed out there was an update, now 2023.1 needs to be added to the list.

@emanuelaepure10
feat: add 2023.1 folder to the logic of writting schemas
a54204c 
Add 2023.1 as a folder from where to copy over the parent folder the older versions.

no-ING
update INSPIRE schemas 7.02.2024
@emanuelaepure10 emanuelaepure10 merged commit 21d7605 into wetransform:master Feb 8, 2024
1 check passed
@stempler stempler deleted the feat/ING-3392 branch February 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stempler stempler stempler approved these changes

Assignees

@emanuelaepure10 emanuelaepure10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuelaepure10 @stempler