Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-18383 Quickstart for MicroProfile LRA #694

Closed
wants to merge 1 commit into from

Conversation

xstefank
Copy link
Member

Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, minor changes needed. Once we get trough those let's bring QE onboard.

microprofile-lra/README.adoc Outdated Show resolved Hide resolved
microprofile-lra/README.adoc Outdated Show resolved Hide resolved
microprofile-lra/README.adoc Outdated Show resolved Hide resolved
microprofile-lra/README.adoc Outdated Show resolved Hide resolved
shared-doc/build-and-deploy-the-quickstart.adoc Outdated Show resolved Hide resolved
shared-doc/build-and-deploy-the-quickstart.adoc Outdated Show resolved Hide resolved
microprofile-lra/pom.xml Outdated Show resolved Hide resolved
microprofile-lra/pom.xml Outdated Show resolved Hide resolved
microprofile-lra/enable-microprofile-lra.cli Outdated Show resolved Hide resolved
@emmartins
Copy link
Contributor

@xstefank there are some test issues too

@xstefank xstefank force-pushed the lra-qs branch 2 times, most recently from b78d3ef to a8a59a1 Compare November 21, 2023 07:23
@@ -77,6 +77,7 @@ ifdef::reactive-messaging[]
$ __{jbossHomeName}__/bin/jboss-cli.sh --connect --file=enable-reactive-messaging.cli
----
endif::reactive-messaging[]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls revert

<feature-pack-location>wildfly@maven(org.jboss.universe:community-universe)#${version.server}</feature-pack-location>
<layers>
<layer>jaxrs-server</layer>
<layer>microprofile-openapi</layer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong layers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed already, a few other issues with the test setup

@xstefank
Copy link
Member Author

GH is not picking up my force pushes for some reason

@xstefank xstefank closed this Nov 21, 2023
@xstefank
Copy link
Member Author

Superseded by #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants