-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-18383 Quickstart for MicroProfile LRA #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, minor changes needed. Once we get trough those let's bring QE onboard.
microprofile-lra/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
@xstefank there are some test issues too |
b78d3ef
to
a8a59a1
Compare
@@ -77,6 +77,7 @@ ifdef::reactive-messaging[] | |||
$ __{jbossHomeName}__/bin/jboss-cli.sh --connect --file=enable-reactive-messaging.cli | |||
---- | |||
endif::reactive-messaging[] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls revert
microprofile-lra/pom.xml
Outdated
<feature-pack-location>wildfly@maven(org.jboss.universe:community-universe)#${version.server}</feature-pack-location> | ||
<layers> | ||
<layer>jaxrs-server</layer> | ||
<layer>microprofile-openapi</layer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong layers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed already, a few other issues with the test setup
GH is not picking up my force pushes for some reason |
Superseded by #778 |
https://issues.redhat.com/browse/WFLY-18383