WFLY-18508 spring-resteasy Quickstart Common Enhancements CY2023Q3

[liweinan]

https://issues.redhat.com/browse/WFLY-18508

[liweinan]

@emmartins @jamezp I start to work on this according to the changes in: #711

It's still in draft and I'll complete the missing parts. Currently the integration-test and existing tests can pass.

[liweinan]

The JDK11 can not be used because this example needs at least JDK17.

[liweinan]

@emmartins Thanks for checking! I'll modify the test accordingly. In addition, this test can only be run under JDK16 (because of the Spring dep). What can I do to fix this?

[liweinan]

After removing the arq profiles the tests can be executed this way:

➤ mvn wildfly:run -Pprovisioned-server

➤ mvn verify -Pintegration-testing -Dserver.host=http://localhost:8080/                                                                                                                                                                                                                     00:04:11

I will cleanup this PR and squash the commits after everything is fixed.

[emmartins]

@emmartins Thanks for checking! I'll modify the test accordingly. In addition, this test can only be run under JDK16 (because of the Spring dep). What can I do to fix this?

Let's ignore the test fails for now, I guess we should expose the matrix JDK choices, similar to MATRIX_OS, which will then allow you to send something like MATRIX_JDK: '"17"' to not test JDK 11.

[emmartins]

After removing the arq profiles the tests can be executed this way:

➤ mvn wildfly:run -Pprovisioned-server

➤ mvn verify -Pintegration-testing -Dserver.host=http://localhost:8080/                                                                                                                                                                                                                     00:04:11

I will cleanup this PR and squash the commits after everything is fixed.

ok seems I missed something, you didn't update the README.adoc as specified by:

• https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.bksczecrc5z2
• https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.fz37de8en4v

The content included above provides you the testing instructions, which use wildfly:start -DjbossHome=... (as followup of mvn package -Pprovisioned-server), which are the instructions being tested by the CI. I will consider a 'post-enhancements' move to wildfly:run single command instead, but for now let's have all QS using same ok?

[emmartins]

We need also plugin management to be added, please see https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.rcftxwtudvl5

[liweinan]

@emmartins I have added the plugin management section, not sure I add it correctly or not. In addition I found the batch-proessing example doesn't have this section either:

• https://github.com/wildfly/quickstart/blob/main/batch-processing/pom.xml

Shall I add the section their too?

[emmartins]

Since this is not a MicroProfile quickstart you don't need the wildfly-jar plugin

[emmartins]

Wrt batch-processing it was fixed yesterday :-)

[liweinan]

Wrt batch-processing it was fixed yesterday :-)

Cool!

[jamezp]

Spring 6 only works on Java 17+. I'm not sure how we can resolve this because of the workflow call. Creating the workflow matrix in JSON is an option, but likely not a great one. However, the other option is to not call the workflow.

[liweinan]

Spring 6 only works on Java 17+. I'm not sure how we can resolve this because of the workflow call. Creating the workflow matrix in JSON is an option, but likely not a great one. However, the other option is to not call the workflow.

Maybe we can split the CI file for Java 11 or 17? @emmartins wdyt?

[liweinan]

@emmartins Thanks for the advice! I'll update the README accordingly.

After removing the arq profiles the tests can be executed this way:

➤ mvn wildfly:run -Pprovisioned-server

➤ mvn verify -Pintegration-testing -Dserver.host=http://localhost:8080/                                                                                                                                                                                                                     00:04:11

I will cleanup this PR and squash the commits after everything is fixed.

ok seems I missed something, you didn't update the README.adoc as specified by:

• https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.bksczecrc5z2
• https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.fz37de8en4v

The content included above provides you the testing instructions, which use wildfly:start -DjbossHome=... (as followup of mvn package -Pprovisioned-server), which are the instructions being tested by the CI. I will consider a 'post-enhancements' move to wildfly:run single command instead, but for now let's have all QS using same ok?

[emmartins]

@liweinan @jamezp no worries wrt the JDK, I will later update the quickstart_ci.yml to allow quickstarts to customize the matrix JDKs, I will do it elsewhere to avoid multiple runs of all QS workflows. For now please simply ignore the JDK 11 test fails.

[liweinan]

@liweinan @jamezp no worries wrt the JDK, I will later update the quickstart_ci.yml to allow quickstarts to customize the matrix JDKs, I will do it elsewhere to avoid multiple runs of all QS workflows. For now please simply ignore the JDK 11 test fails.

Thanks!

[liweinan]

The tests passed locally with the following command:

$ mvn clean package -Pprovisioned-server

$ mvn wildfly:start -DjbossHome=target/server

➤  mvn verify -Pintegration-testing -Dserver.host=http://localhost:8080

[liweinan]

@emmartins I have updated the doc and the tests passed in JDK17, so I mark this PR as ready for preview. Please let me know if there is anything else need to be changed :D

[emmartins]

Looks good to me, only one more change, please squash the commits into one.

[liweinan]

@emmartins Done!

[emmartins]

thank you @liweinan

[emmartins]

FYI I created https://issues.redhat.com/browse/WFLY-18689 to deliver the matrix.jdk customization this QS needs. As I said before I will leave this to post-enhancements.

[emmartins]

@liweinan FYI WFLY-18689 was now fixed, which included the changes in this quickstart yml to only test it on JDK 17

[liweinan]

@liweinan FYI WFLY-18689 was now fixed, which included the changes in this quickstart yml to only test it on JDK 17

Cool!

[liweinan]

Relative PR: #767