Merge branch 'chore/rust1.81' into ci-update-and-refactor-all-actions

Justfile

@@ -35,6 +35,7 @@ export CLIPPY_LINTS := '-D warnings
     -D clippy::checked-conversions
     -A clippy::upper-case-acronyms
     -A clippy::uninlined-format-args
+    -A renamed_and_removed_lints
 '
 
 # run clippy

bridges/centralized-ethereum/src/actors/eth_poller.rs

@@ -94,13 +94,11 @@ impl EthPoller {
                     None,
                 )
                 .await
-                .map_err(|err| {
+                .inspect_err(|err| {
                     log::error!(
                         "Fail to read getNextQueryId from contract: {:?}",
                         err.to_string()
-                    );
-
-                    err
+                    )
                 });
 
             let last_dr_id = dr_database_addr.send(GetLastDrId).await;

data_structures/Cargo.toml

@@ -28,7 +28,7 @@ num_enum = "0.4.2"
 num-traits = "0.2.15"
 ordered-float = "3.0"
 partial_struct = { path = "../partial_struct" }
-protobuf = { version = "2.23.0", features = ["with-serde"] }
+protobuf = { version = "2.28.0", features = ["with-serde"] }
 protobuf-convert = "0.1.1"
 rand = "0.8.5"
 serde = { version = "1.0.104", features = ["derive"] }

node/src/actors/chain_manager/mining.rs

@@ -855,7 +855,7 @@ impl ChainManager {
                         log::info!(
                             "{} Created Tally for Data Request {} with result: {}\n{}",
                             Yellow.bold().paint("[Data Request]"),
-                            Yellow.bold().paint(&dr_pointer.to_string()),
+                            Yellow.bold().paint(dr_pointer.to_string()),
                             Yellow
                                 .bold()
                                 .paint(format!("{}", &tally_result.into_inner())),

node/src/actors/epoch_manager/mod.rs

@@ -129,8 +129,8 @@ impl EpochManager {
             .and_then(|config, act, ctx| {
                 let checkpoint_zero_timestamp_v2 =
                     config.consensus_constants.checkpoint_zero_timestamp
-                        + get_protocol_version_activation_epoch(ProtocolVersion::V2_0) as i64
-                            * config.consensus_constants.checkpoints_period as i64;
+                        + i64::from(get_protocol_version_activation_epoch(ProtocolVersion::V2_0))
+                            * i64::from(config.consensus_constants.checkpoints_period);
                 act.set_checkpoint_zero_and_period(
                     config.consensus_constants.checkpoint_zero_timestamp,
                     config.consensus_constants.checkpoints_period,

node/src/actors/sessions_manager/actor.rs

@@ -46,8 +46,8 @@ impl Actor for SessionsManager {
                 let checkpoint_zero_timestamp =
                     config.consensus_constants.checkpoint_zero_timestamp;
                 let checkpoint_zero_timestamp_v2 = checkpoint_zero_timestamp
-                    + get_protocol_version_activation_epoch(ProtocolVersion::V2_0) as i64
-                        * checkpoints_period as i64;
+                    + i64::from(get_protocol_version_activation_epoch(ProtocolVersion::V2_0))
+                        * i64::from(checkpoints_period);
                 let checkpoints_period_v2 = get_protocol_version_period(ProtocolVersion::V2_0);
                 let epoch_constants = EpochConstants {
                     checkpoint_zero_timestamp,

node/src/config_mngr.rs

@@ -121,10 +121,7 @@ impl actix::Handler<Load> for ConfigManager {
 
     fn handle(&mut self, Load(source): Load, _ctx: &mut Self::Context) -> Self::Result {
         self.load_config(&source)
-            .map(|r| {
-                log::info!("Loaded new configuration from source: {:?}", source);
-                r
-            })
+            .inspect(|_| log::info!("Loaded new configuration from source: {:?}", source))
             .map_err(|e| {
                 log::error!(
                     "Failed to load new configuration from source: {:?}, error: {}",

rad/src/lib.rs

@@ -458,11 +458,11 @@ pub async fn run_paranoid_retrieval(
 /// There are 4 cases in which this function will fail with `InconsistentSource`:
 ///
 /// 1. All the transports failed or no transports are configured at all (in theory, this condition
-/// should be unreachable).
+///    should be unreachable).
 /// 2. The retrieval failed on some of the used transports.
 /// 3. The values that we got from different transports cannot be aggregated together.
 /// 4. The result of applying the aggregation on the data coming from the different transports
-/// reached a level of consensus that is lower than the configured paranoid threshold.
+///    reached a level of consensus that is lower than the configured paranoid threshold.
 fn evaluate_paranoid_retrieval(
     data: Vec<Result<RadonReport<RadonTypes>>>,
     aggregate: RADAggregate,

validations/src/eligibility/current.rs

@@ -232,24 +232,27 @@ where
         // Requirement no. 3 from the WIP:
         //  "the big-endian value of the VRF output is less than
         //  `max_rounds * own_power / (round * threshold_power + max_power * (max_rounds - round))`"
-        let dividend = Power::from(WITNESSING_MAX_ROUNDS as u64)
+        let dividend = Power::from(u64::from(WITNESSING_MAX_ROUNDS))
             * Power::from((u64::BITS - u64::from(power).leading_zeros()).into());
-        let divisor = (round as u32)
+        let divisor = u32::from(round)
             .saturating_mul(u64::BITS - u64::from(threshold_power).leading_zeros())
             .saturating_add(
                 (u64::BITS - u64::from(max_power).leading_zeros())
-                    .saturating_mul(WITNESSING_MAX_ROUNDS - round as u32),
+                    .saturating_mul(WITNESSING_MAX_ROUNDS - u32::from(round)),
             );
         let (target_hash, probability) = if divisor == 0 {
             (Hash::with_first_u32(u32::MAX), 1_f64)
         } else {
             let hash = Hash::with_first_u32(
-                (((u64::MAX / Power::from(divisor as u64)).saturating_mul(u64::from(dividend)))
+                (((u64::MAX / Power::from(u64::from(divisor)))
+                    .saturating_mul(u64::from(dividend)))
                     >> 32)
                     .try_into()
                     .unwrap(),
             );
-            let probability = u64::from(dividend) as f64 / divisor as f64;
+
+            #[allow(clippy::cast_precision_loss, clippy::cast_lossless)]
+            let probability: f64 = u64::from(dividend) as f64 / divisor as f64;
 
             (hash, probability)
         };

wallet/src/lib.rs

@@ -55,8 +55,8 @@ pub fn run(conf: Config) -> Result<(), Error> {
     let checkpoints_period = conf.consensus_constants.checkpoints_period;
     let checkpoint_zero_timestamp = conf.consensus_constants.checkpoint_zero_timestamp;
     let checkpoint_zero_timestamp_v2 = checkpoint_zero_timestamp
-        + get_protocol_version_activation_epoch(ProtocolVersion::V2_0) as i64
-            * checkpoints_period as i64;
+        + i64::from(get_protocol_version_activation_epoch(ProtocolVersion::V2_0))
+            * i64::from(checkpoints_period);
     let checkpoints_period_v2 = get_protocol_version_period(ProtocolVersion::V2_0);
     let epoch_constants = EpochConstants {
         checkpoint_zero_timestamp,