Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] include a delay in block broadcasting to mitigate late blocks #2120

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[PoC] include a delay in block broadcasting to mitigate late blocks #2120

wants to merge 3 commits into from

Conversation

lrubiorod
Copy link
Contributor

Close #2117

@lrubiorod lrubiorod mentioned this pull request Nov 26, 2021
Closed
@lrubiorod lrubiorod changed the title feat(node): include a delay in block broadcasting [PoC] include a delay in block broadcasting to mitigate late blocks Nov 26, 2021
tmpolaczyk
tmpolaczyk reviewed Nov 26, 2021
View reviewed changes
node/src/actors/chain_manager/mod.rs
@@ -3528,19 +3593,19 @@ mod tests {
assert_ne!(block_1, block_mal_1);

// Process the modified candidate first
chain_manager.process_candidate(block_mal_1);
chain_manager.process_candidate(&mut Context::new(), block_mal_1, (0, 0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it was possible to call Context::new()... But maybe it's better to send an AddCandidates message? This is inside an async block so we can just call send().await.

@aesedepece aesedepece force-pushed the master branch 3 times, most recently from 6b3142a to 9781266 Compare October 18, 2022 13:01
@aesedepece aesedepece force-pushed the master branch 2 times, most recently from 3e8bb07 to ed5e532 Compare May 17, 2023 09:39
@aesedepece aesedepece force-pushed the master branch 3 times, most recently from d28f025 to 5bf0421 Compare January 4, 2024 17:37
@aesedepece aesedepece force-pushed the master branch 3 times, most recently from 9e47bbb to eece408 Compare November 13, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmpolaczyk tmpolaczyk tmpolaczyk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PoC: late blocks retention delay
2 participants
@lrubiorod @tmpolaczyk