Fix clippy warnings to rust 1.73 #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
force-pushed
the
fix/clippy-errors-0.1.73
branch
from
c1ccea0 to
7c2e7e6
Compare
Fix clippy warning for rust 1.73. Replace `or_insert_with` with `or_default`
Tommytrg
force-pushed
the
fix/clippy-errors-0.1.73
branch
from
7c2e7e6 to
0065952
Compare
Fix clippy warnings to rust 1.73. Refactor code to use a `.fold` to return a `Vec<String>` instead of use `format!` in a `.map`.
Get the pkh and call `to_string` in the same `.map` instead of doing it in two different iterations.
Tommytrg
force-pushed
the
fix/clippy-errors-0.1.73
branch
from
0065952 to
7ab51a9
Compare
Tommytrg
changed the title
aesedepece
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.foldto return aVec<String>instead of useformat!in a.map.or_insert_withwithor_defaultto_stringin the same.mapinstead of doing it in two different iterations.