Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: unify runtime again #2914

Merged
merged 7 commits into from
Nov 1, 2023
Merged

refactor!: unify runtime again #2914

merged 7 commits into from
Nov 1, 2023

Conversation

barak007
Copy link
Collaborator

@barak007 barak007 commented Oct 2, 2023 •
edited by idoros
Loading

This PR refactors the runtime code of stylable to streamline the generation of Stylable JS module sources, ensuring better consistency and clarity in the output.

breaking changes:

  • cli: build of runtime stylable-esm-runtime.js has changed to stylable-esm-runtime.mjs
  • runtime: expose package.json exports instead of internal paths to dist for esm/cjs
  • runtime: remove support for server css rendering - build CSS in advance

barak007
barak007 commented Oct 2, 2023
View reviewed changes
packages/node/src/loader.ts Outdated Show resolved Hide resolved
@barak007 barak007 marked this pull request as ready for review November 1, 2023 10:51
@idoros idoros added tech debt Updates, upgrades, stale code and work-arounds runtime Runtime API labels Nov 1, 2023
@idoros idoros self-requested a review November 1, 2023 13:01
@barak007 barak007 merged commit 2f77914 into master Nov 1, 2023
12 checks passed
@barak007 barak007 deleted the barak/uni-runtime-2 branch November 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoros idoros idoros approved these changes

Assignees

@barak007 barak007

Labels
runtime Runtime API tech debt Updates, upgrades, stale code and work-arounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barak007 @idoros