Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: convert eslint plugin to esm #2930

Merged
merged 6 commits into from
Dec 13, 2023
Merged

chore!: convert eslint plugin to esm #2930

merged 6 commits into from
Dec 13, 2023

Conversation

barak007
Copy link
Collaborator

@barak007 barak007 commented Dec 13, 2023 •
edited by idoros
Loading

  • upgrade eslint dependencies to version 6 (esm only)
  • change eslint-plugin-stylable to esm only to handle upgrade

more and more dependencies are moving into esm so we need to adopt.

@idoros
Copy link
Collaborator

idoros commented Dec 13, 2023 •
edited
Loading

We can open the discussion about moving to esm, can we support dual mode easily?

@idoros idoros self-requested a review December 13, 2023 10:48
@idoros idoros changed the title infra: convert eslint plugin to esm chore!: convert eslint plugin to esm Dec 13, 2023
@idoros idoros merged commit 2c441dd into master Dec 13, 2023
12 checks passed
@idoros idoros deleted the barak/eslint-esm branch December 13, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoros idoros idoros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barak007 @idoros