Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ignoreDeprecations from ts-config #2937

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore: remove ignoreDeprecations from ts-config #2937

merged 1 commit into from
Feb 1, 2024

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Jan 28, 2024

This PR removes the ignoreDeprecations typescript compile option.
The deprecation ignore config is supposed to last until 5.4 (typescript is currently at 5.3.3).

We should try to enable verbatimModuleSyntax instead of the deprecated importsNotUsedAsValues config.

@idoros idoros added the tech debt Updates, upgrades, stale code and work-arounds label Jan 28, 2024
@idoros idoros requested a review from barak007 January 28, 2024 09:04
@idoros idoros self-assigned this Jan 28, 2024
@idoros idoros merged commit 40ea1b3 into master Feb 1, 2024
12 checks passed
@idoros idoros deleted the ido/remove-ts-ignoredeprecations branch February 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees

@idoros idoros

Labels
tech debt Updates, upgrades, stale code and work-arounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idoros @barak007