Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make imports "type": "module" ready #2978

Merged
merged 1 commit into from
Jan 15, 2025
Merged

refactor: make imports "type": "module" ready #2978

merged 1 commit into from
Jan 15, 2025

Conversation

AviVahl
Copy link
Collaborator

@AviVahl AviVahl commented Jan 14, 2025

  • also renamed .mocharc.js to cjs
  • should reduce the noise significantly when doing the migration

@AviVahl
refactor: make imports "type": "module" ready
adebab0 
- also renamed .mocharc.js to cjs
- should reduce the noise significantly when doing the migration
idoros
idoros approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@idoros idoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!
Are you doing all of this manually?

@AviVahl
Copy link
Collaborator Author

AviVahl commented Jan 15, 2025

Mostly search/replace, but also needed to go over them one by one, reverting some changes, as non-import statements also got changed (strings in tests that import stuff).

@AviVahl AviVahl merged commit 899a283 into master Jan 15, 2025
12 checks passed
@AviVahl AviVahl deleted the avi/native-esm-compatible-imports branch January 15, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoros idoros idoros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AviVahl @idoros