Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT2024-2 GRIB2 #273

Merged
merged 14 commits into from
Nov 7, 2024
Merged

FT2024-2 GRIB2 #273

merged 14 commits into from
Nov 7, 2024

Conversation

amilan17
Copy link
Member

No description provided.

efucile and others added 3 commits July 8, 2024 12:03
…ntile distribution instead of based on a threshold (#265)

* fix rebase conflict xml,txt files

* fix rebase conflicts 247 adding entry in COde table 4.9 and associated note

* fix rebase conflicts xml,txt files

* xml,txt files

* #247 changing PDF acronym to probability distribution function

* xml,txt files

* remove odd char

* xml,txt files

* xml,txt files

* remove datestamp from XML gen

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sebastien Villaume <[email protected]>
@amilan17 amilan17 added this to the FT2024-2 milestone Jul 10, 2024
amilan17 and others added 8 commits July 11, 2024 14:31
* xml,txt files

* xml,txt files

* issue #253 update branch

* xml,txt files

* Update GRIB2_CodeFlag_4_2_10_4_CodeTable_en.csv

53 and 54 for normal and tangential component of water velocity, as entry 52 is used in issue 244 for mixed layed depth.

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sibylle Krebber <[email protected]>
…of templates 4105 4106 4107 and 4112 (#263)

* fix rebase conflict: 248 adding entry in Code Table 4.101 and associated note

* fix rebase of xml,txt files

* fix legacy conflict text

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
…0 1 (#262)

* issue #244 in NEW branch

* xml,txt files

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
* #246 adding template 4.128 to 4.136 and entries in code table 4.0

* rebase fix xml,txt files

* Update GRIB2_Template_4_129_ProductDefinitionTemplate_en.csv

Replace "to" with "-"

* xml,txt files

* Update GRIB2_Template_4_131_ProductDefinitionTemplate_en.csv

upper limit

* xml,txt files

* Update GRIB2_Template_4_134_ProductDefinitionTemplate_en.csv

"51-62" not as octetNo

* xml,txt files

* Update GRIB2_Template_4_136_ProductDefinitionTemplate_en.csv

upper limit and typo in line 47

* xml,txt files

* fix CSV

* xml,txt files

* Apply suggestions from code review

update see note references

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sibylle Krebber <[email protected]>
…269)

* #245 deprecate template 4.44, create new corrected template 4.50 and update Code table 4.0 accordingly

* xml,txt files

* Update GRIB2_CodeFlag_4_0_CodeTable_en.csv

* xml,txt files

* Update GRIB2_Template_4_50_ProductDefinitionTemplate_en.csv

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
…and a new parameter in code table 42 discipline 0 category 20 (#274)

* #250 adding entries in code table 4.22.0.20 and 4.238

* xml,txt files

* #250 updating entries to only keep sink and source (removing loss and gain)

* xml,txt files

* xml,txt files

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
#238

* xml,txt files

* 271 remove date from xml script (#272)

* xml,txt files

* Update create_master_lists.py

Remove the generation of the 'generated' param to avoid complex merging process.

Now the xml header won't have the 'generated' param anymore

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>

* xml,txt files

* xml,txt files

* update branch for issue #238

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: antoineMerleEUM <[email protected]>
…e of forecasting (#261)

#249 
* fix rebase conflict: 249 adding entries in code table 1.4, 4.3 and 4.6 with associated notes

* fix rebase of xml,txt files

* #249, add notes, change sample to example

* xml,txt files

* editorial, changed 23 to 22 in CF4.3

* xml,txt files

* Update GRIB2_CodeFlag_4_6_CodeTable_en.csv

Co-authored-by: Marijana Crepulja <[email protected]>

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Marijana Crepulja <[email protected]>
notes/CodeFlag_notes.csv Outdated Show resolved Hide resolved
amilan17 and others added 3 commits August 8, 2024 13:49
…in discipline land surface and associated parameters (#266)

* #251 adding entries in subtables of codec table 4.2

* fix rebase conflicts for xml,txt files

* change capitilization

* xml,txt files

* #251 add notes

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

add note number

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

change note number again

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
* Code table 1.4, 4.3 and 4.6: Adding new entries to better describe type of forecasting #249

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question in template 4.50

@amilan17 amilan17 changed the title FT2024-2 FT2024-2 GRIB2 Aug 21, 2024
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@amilan17 amilan17 merged commit 4b0faf0 into master Nov 7, 2024
1 check passed
@amilan17 amilan17 deleted the FT2024-2 branch November 7, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved by President of WMO
Development

Successfully merging this pull request may close these issues.

3 participants