tilt: solana-test-validator multi-platform support #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
force-pushed
the
tilt-m1
branch
5 times, most recently
from
314adc7 to
a397e8e
Compare
|
Should be passable on Mac with 4 CPU and 8 GB RAM allocated (at least for the run, not sure on the build which likely uses more). This test run was done with 8 CPU 24 GB RAM.
|
nvsriram
previously approved these changes
Dec 6, 2024
evan-gray
force-pushed
the
tilt-m1
branch
2 times, most recently
from
a47fd43 to
cb2e671
Compare
evan-gray
changed the title
johnsaigle
reviewed
Dec 10, 2024
nvsriram
approved these changes
Dec 10, 2024
|
@johnsaigle the CLI check is not a required check. There is an open PR from @nvsriram to fix this: #573 |
johnsaigle
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for solana-test-validator within Docker / Tilt for M-series Macs. See also wormhole-foundation/wormhole#4175 and wormhole-foundation/wormhole#4181 which made this possible.
It also changes the
sedline to one that works on Mac and Linux / WSL. To confirm that line still works in ci, I did a run with the guardian log level oninfohere where you can search for8bf0b547c96edc5c1d512ca25c5c1d1812a180438a0046e511d1fb61561d5cdfand the other emitters added to confirm they are being accounted (search forgacctguardian logs).Bonus: this changes the result of
solana/Dockerfileto only contain the required artifacts, reducing the image size from 24.82 GB to 5.27 MB!oh, and you can now run
tilt up -- --evm2 --generic_relayer --solana_watcher --wormchain --guardiand_loglevel=warnon your Mac just like in CI and it passes!