Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ilariae/security #2

Merged
merged 35 commits into from
Jul 31, 2024
Merged

Ilariae/security #2

merged 35 commits into from
Jul 31, 2024

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Jul 26, 2024

Description

Added security page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

eshaben
eshaben reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I think the biggest things with this PR were the over-usage of bold text and consistent capitalization of specific words

learn/introduction.md Outdated Show resolved Hide resolved
learn/security.md Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Outdated Show resolved Hide resolved
learn/security.md Show resolved Hide resolved
Ilaria Enache and others added 22 commits July 29, 2024 11:37
deleted intro to avoid conflict
67738da
added meta title and description
4316d7e
@ilariae @eshaben
Update learn/security.md
c330845 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
a0b25be 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
a036203 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
902a2a8 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
42ac9ea 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
1efa3b7 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
383b646 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
fdfd48d 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
7d14166 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
1025153 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
5865bf3 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
fea029b 
Co-authored-by: Erin Shaben <[email protected]>
update security page
78081c9
Resolved merge conflict in learn/security.md
dd66cea
@ilariae @eshaben
Update learn/security.md
9e1ec99 
Co-authored-by: Erin Shaben <[email protected]>
Merge remote-tracking branch 'origin/ilariae/security' into ilariae/s…
12723d3 
…ecurity
@ilariae @eshaben
Update learn/security.md
8e6d9fb 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
687739d 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae @eshaben
Update learn/security.md
9549997 
Co-authored-by: Erin Shaben <[email protected]>
Resolved conflicts in learn/security.md
259fbec
eshaben
eshaben approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@eshaben
Copy link
Collaborator

eshaben commented Jul 30, 2024

@ilariae I thought we were going to resolve this by deleting the file, haha, but I guess not. Can you please resolve merge conflicts?

@ilariae ilariae merged commit 9e5e23c into main Jul 31, 2024
1 check passed
@ilariae ilariae deleted the ilariae/security branch July 31, 2024 09:28
@themacexpert themacexpert mentioned this pull request Aug 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilariae @eshaben