Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize connectors #807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

normalize connectors #807

wants to merge 1 commit into from

Conversation

kakasoo
Copy link
Collaborator

@kakasoo kakasoo commented Dec 20, 2024

Test before submitting

Before submitting a Pull Request, please test your code. If you created a new created a new feature, then create the test function, too. Please refer to this document.

Put the name of the test function of the service you created in the command below.
This is a regular expression that returns all tests containing the character string, so if there are several test codes, you can put a keyword including all of the test codes and turn them.
If you omit the include statement and operate the test, all the test codes we write will work, and myriad errors will occur in your code without environmental variables.

npm run build && npm run test -- --include TEST_FUNCTION_NAME

Of course you won't be able to provide us with your environmental variables, so we'll replace them with our environmental variables to run the program and merge it depending on whether it passes or not.

Purpose

Please explain to our developers what the features you modified or developed are for.

Check List

  • Passing an existing or newly created test
  • sufficient summary and description for LLM to understand
  • Does it ensure backward compatibility with existing features, or does the modifications not affect pre-modification request, response type?

@kakasoo kakasoo self-assigned this Dec 20, 2024
kakasoo

This comment was marked as resolved.

@seunghwako
Copy link
Contributor

@kakasoo 이거 PR 닫아도 되나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants