Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay build status information from g-s-b #45

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Relay build status information from g-s-b #45

merged 6 commits into from
Feb 13, 2024

Conversation

sersorrel
Copy link
Member

Add status information to the GraphQL Environment type, populated with data from go-softpack-builder. Additionally, use that information to avoid having builds remain marked as "queued" forever – if the builder doesn't know about them, assume they've failed and the failure got lost (e.g. the builder was restarted mid-build).

Generated with:

```
poetry run strawberry export-schema softpack_core.graphql:GraphQL.schema > schema.graphql
```
if the builder loses track of a build, it's not coming back (currently)
@sersorrel sersorrel requested review from sb10 and mjkw31 February 13, 2024 14:11
@sersorrel sersorrel requested a review from altaf-ali as a code owner February 13, 2024 14:11
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (72e98fa) 63.13%.
Report is 8 commits behind head on develop.

Files Patch % Lines
softpack_core/schemas/environment.py 26.74% 63 Missing ⚠️
softpack_core/artifacts.py 76.92% 3 Missing ⚠️
softpack_core/schemas/groups.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    65.29%   63.13%   -2.16%     
===========================================
  Files           16       17       +1     
  Lines          775      868      +93     
  Branches       131      153      +22     
===========================================
+ Hits           506      548      +42     
- Misses         262      313      +51     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 merged commit 2c63b62 into develop Feb 13, 2024
3 of 5 checks passed
@sb10 sb10 deleted the build-status branch February 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants