Fixed a bug in generating the product ID. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdstrike
approved these changes
Feb 19, 2024
An existing bug in constructing a JSON representation for a Pydantic model when the plate_number attribute is 2 or larger resulted in incorrect IDs being generated. This came to light while testing https://github.com/wtsi-npg/npg_langqc against release 5.0.0 of this package. The fix includes a return to using Pydantic models' built-in model_dump_json method in order to mitigate the risk that comes manual generation of JSON strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing bug in constructing a JSON representation for a Pydantic model when the plate_number attribute is 2 or larger resulted in incorrect IDs being generated. This came to light while testing https://github.com/wtsi-npg/npg_langqc against release 5.0.0 of this package.
The fix includes a return to using Pydantic models' built-in model_dump_json method in order to mitigate the risk that comes manual generation of JSON strings.