Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped generating InstrumentFormat ORM class. #818

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Apr 9, 2024

Dropped instrument_utilisation table from the db schema, which is used for testing the tracking web application.

'instrument_utilisation' table has not been used for the last seven years. The code that filled it in was deleted some time ago.

Once this change is released, the 'instrument_utilisation' table can be dropped from the prod. database.

mgcam added 2 commits April 9, 2024 10:46
Dropped instrument_utilisation table from the db schema,
which is used for testing the tracking web application.

'instrument_utilisation' table has not been used for the
last seven years. The code that filled it in was deleted
some time ago.

Once this change is released, the 'instrument_utilisation'
table can be dropped from the prod. database.
The code does not form a part of any of the unit tests.
When run, it results in meaningless console output.
@jmtcsngr
Copy link
Member

There is still a view for instrument_utilisation declared in data/config.ini (last item in the list). Do we need it if there is no ORM?

@mgcam
Copy link
Member Author

mgcam commented Apr 16, 2024

There is still a view for instrument_utilisation declared in data/config.ini (last item in the list). Do we need it if there is no ORM?

No, but there are plenty of views there, which do not exist. This one will be yet another one.

@jmtcsngr jmtcsngr merged commit ec78f7d into wtsi-npg:devel Apr 16, 2024
2 checks passed
@mgcam mgcam deleted the drop_instr_util_ORM_class branch January 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants