Refactored runs listing. #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new optional parameter to methods returning lists of runs and run count - the name of the manufacturer. If this name is undefined in the parameters hash, it defaults to 'Illumina'. To avoid code repetition, consolidated queries for listing and counting runs, which previously were in six different places. Simplified the logic of retrieving cached lists and counts of runs vs computing new values.
mgcam
force-pushed
the
multi-manufacturer-run-views
branch
from
d391bbc to
8fc4fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new optional parameter to methods
returning lists of runs and run count - the name of the manufacturer. If this name is undefined in the parameters hash, it defaults to 'Illumina'.
To avoid code repetition, consolidated queries for listing and counting runs, which wer epreviously
in six different places.
Simplified the logic of retrieving cached lists
and counts of runs vs computing new values.