Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echarlie donation improvements #22

Merged
merged 9 commits into from
Jun 4, 2021
Merged

Echarlie donation improvements #22

merged 9 commits into from
Jun 4, 2021

Conversation

echarlie
Copy link
Member

@echarlie echarlie commented May 28, 2021 •
edited
Loading

supercedes wuvt/wuvt-site#385

fixes #12
partial #15

This was referenced May 28, 2021
Closed
Open
@echarlie echarlie mentioned this pull request May 28, 2021
Merged
5 tasks
echarlie
echarlie commented Jun 1, 2021
View reviewed changes
Copy link
Member Author

@echarlie echarlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apparently can't "request changes" on my own review. But I made some notes so that I look at these specific issues.

donormotor/templates/admin/donation_index.html Outdated Show resolved Hide resolved
donormotor/admin/views.py Show resolved Hide resolved
donormotor/templates/admin/donation_index.html Outdated Show resolved Hide resolved
JasonDavidoff85
JasonDavidoff85 approved these changes Jun 1, 2021
View reviewed changes
Copy link

@JasonDavidoff85 JasonDavidoff85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt launch it myself but seems good

@echarlie echarlie mentioned this pull request Jun 2, 2021
Open
@echarlie echarlie merged commit 470db6a into base_work Jun 4, 2021
@echarlie echarlie deleted the echarlie-donation-improvements branch June 4, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonDavidoff85 JasonDavidoff85 JasonDavidoff85 approved these changes

@mutantmonkey mutantmonkey mutantmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echarlie @mutantmonkey @JasonDavidoff85