This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 689
Updated OpenId Android to AndroidX #1227
Open
albertb22
wants to merge
11
commits into
xamarin:main
Choose a base branch
from
albertb22:OpenId.AndroidX
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How do i link this pull-request to this issues #1019? |
moljac
reviewed
Jul 16, 2021
XPlat/OpenId/iOS/source/OpenId.AppAuth.iOS/OpenId.AppAuth.iOS.csproj
Outdated
Show resolved
Hide resolved
@moljac When will this be merged to master and get an updated Xamarin.OpenId.AppAuth.Android package. |
moljac
suggested changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AndroidX and GPS-FB-MLKit target MonoAndroid9.0
so please change this until we bump rest
otherwise LGTM
XPlat/OpenId/Android/source/OpenId.AppAuth.Android/OpenId.AppAuth.Android.csproj
Outdated
Show resolved
Hide resolved
@moljac When will this be reviewed and do you have any idea on when there will be updated Xamarin.OpenId.AppAuth.Android package. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the OpenId Android package to AndroidX.
I didn't yet update the Sample project for Android.
If this is necessary I will look into it.