daemons: Log POSIX signal names alongside their numbers in handlers #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes xapi-project#6225 Signed-off-by: Andrii Sultanov <[email protected]>
robhoes
reviewed
Jan 14, 2025
| @@ -53,7 +53,9 @@ let on_shutdown signal = | |||
| let dbg = "shutdown" in | |||
| Debug.with_thread_associated dbg | |||
| (fun () -> | |||
| debug "xcp-networkd caught signal %d; performing cleanup actions." signal ; | |||
| debug "xcp-networkd caught signal %s (%d); performing cleanup actions." | |||
| Fmt.(to_to_string Dump.signal signal) | |||
There was a problem hiding this comment.
That's nice... will it print things like SIGTERM?
There was a problem hiding this comment.
yes! waiting for a host to reboot to test this out outside of utop
There was a problem hiding this comment.
I was working on a fix before the bug got opened... #6228
|
Closing in favor of more thorough #6228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6225