CP-52744: Thread TraceContext as JSON inside debug_info
#6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality to marshal and unmarshal `TraceContext` in the tracing library. Instead of passing only the `traceparent` in `debug_info`, the entire `TraceContext` is now passed as JSON. This change enables the transfer of baggage across xenopsd boundaries, improving tracing propagation and debugging capabilities. This should also enable later use of `baggage` as means of passing the thread classification between components. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
9bc7086 to
39d5dfc
Compare
edwintorok
reviewed
Jan 15, 2025
ocaml/libs/tracing/tracing.ml
Outdated
|
|
||
| type baggage = (string * string) list | ||
| type baggage = (string * string) list [@@deriving yojson] |
There was a problem hiding this comment.
we usually use rpcty for deriving (and then we can transform that into json with Rpcmarshal)
(and we can then also choose a more efficient serialization format in the future, I think when I last tested 'csexp' was faster than json)
There was a problem hiding this comment.
Here ff91579.
There was a problem hiding this comment.
I am not sure that I agree with @edwintorok here; this is clearly unrelated to RPC, so I think deriving JSON is fine. However, I am not sure what happens here - what JSON are we expecting here and what is the relation with (string * string) list (a key-value list, I assume).
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
5aec6e6 to
ff91579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to marshal and unmarshal
TraceContextin the tracing library.Instead of passing only the
traceparentindebug_info, the entireTraceContextis now passed as JSON.This change enables the transfer of baggage across xenopsd boundaries, improving tracing propagation and debugging capabilities. This should also enable later use of
baggageas means of passing the thread classification between components.